Merge lp:~seyeongkim/charms/trusty/ceph-radosgw/lp1353246 into lp:~openstack-charmers-archive/charms/trusty/ceph-radosgw/next
Proposed by
Seyeong Kim
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 25 | ||||
Proposed branch: | lp:~seyeongkim/charms/trusty/ceph-radosgw/lp1353246 | ||||
Merge into: | lp:~openstack-charmers-archive/charms/trusty/ceph-radosgw/next | ||||
Diff against target: |
19 lines (+2/-2) 2 files modified
files/www/s3gw.fcgi (+1/-1) templates/ceph.conf (+1/-1) |
||||
To merge this branch: | bzr merge lp:~seyeongkim/charms/trusty/ceph-radosgw/lp1353246 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Edward Hope-Morley | Needs Fixing | ||
Review via email: mp+229734@code.launchpad.net |
To post a comment you must log in.
Hmm, fairly sure this used to be fine. Will this not break backwards compatibility with older versions of Ceph? Also, the ceph charm is expecting this to be client. radosgw. gateway. I guess we have two choices here, either conditionally change files/www/s3gw.fcgi based on what version of ceph is in use or conditionally set this value.