Merge lp:~raoul-snyman/openlp/bug-1018855 into lp:openlp

Proposed by Raoul Snyman
Status: Merged
Approved by: Tim Bentley
Approved revision: 2051
Merged at revision: 2050
Proposed branch: lp:~raoul-snyman/openlp/bug-1018855
Merge into: lp:openlp
Diff against target: 19 lines (+7/-2)
1 file modified
openlp/core/__init__.py (+7/-2)
To merge this branch: bzr merge lp:~raoul-snyman/openlp/bug-1018855
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Jonathan Corwin (community) Approve
Review via email: mp+122410@code.launchpad.net

This proposal supersedes a proposal from 2012-09-02.

Description of the change

Fixed a regression introduced by my bug fix.

To post a comment you must log in.
Revision history for this message
Jonathan Corwin (j-corwin) :
review: Approve
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp/core/__init__.py'
2--- openlp/core/__init__.py 2012-08-31 08:39:38 +0000
3+++ openlp/core/__init__.py 2012-09-02 14:56:18 +0000
4@@ -103,8 +103,13 @@
5 Run the OpenLP application.
6 """
7 self.eventLoopIsActive = False
8- # On Windows, the args passed into the constructor are
9- # ignored. Not very handy, so set the ones we want to use.
10+ # On Windows, the args passed into the constructor are ignored. Not
11+ # very handy, so set the ones we want to use. On Linux and FreeBSD, in
12+ # order to set the WM_CLASS property for X11, we pass "OpenLP" in as a
13+ # command line argument. This interferes with files being passed in as
14+ # command line arguments, so we remove it from the list.
15+ if 'OpenLP' in args:
16+ args.remove('OpenLP')
17 self.args.extend(args)
18 # provide a listener for widgets to reqest a screen update.
19 QtCore.QObject.connect(Receiver.get_receiver(),