Merge lp:~raoul-snyman/openlp/bug-1018855 into lp:openlp

Proposed by Raoul Snyman
Status: Merged
Merged at revision: 2049
Proposed branch: lp:~raoul-snyman/openlp/bug-1018855
Merge into: lp:openlp
Diff against target: 21 lines (+4/-0)
1 file modified
openlp/core/__init__.py (+4/-0)
To merge this branch: bzr merge lp:~raoul-snyman/openlp/bug-1018855
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Review via email: mp+122209@code.launchpad.net

This proposal supersedes a proposal from 2012-08-30.

Commit message

Fixed bug #1018855: Set the WM_CLASS property in X11.

Description of the change

Fixed bug #1018855 by adding a simple string property to the Qt arguments which sets the Window Manager class name (WM_CLASS) in X11.

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote : Posted in a previous version of this proposal

Traceback (most recent call last):
  File "./openlp.pyw", line 44, in <module>
    main()
  File "/home/tim/Projects/openlp/bug-1018855/openlp/core/__init__.py", line 272, in main
    qt_Args.append('OpenLP')
NameError: global name 'qt_Args' is not defined

review: Needs Fixing
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

meh. that's what you get for trying stuff in trunk!

Revision history for this message
Tim Bentley (trb143) wrote :

Testing does help ;-)

review: Approve
lp:~raoul-snyman/openlp/bug-1018855 updated
2049. By Raoul Snyman

Fixed bug #1018855: Set the WM_CLASS property in X11.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp/core/__init__.py'
2--- openlp/core/__init__.py 2012-07-19 17:26:04 +0000
3+++ openlp/core/__init__.py 2012-08-31 08:44:51 +0000
4@@ -35,6 +35,7 @@
5
6 import os
7 import sys
8+import platform
9 import logging
10 from optparse import OptionParser
11 from traceback import format_exception
12@@ -266,6 +267,9 @@
13 qt_args.extend(['-style', options.style])
14 # Throw the rest of the arguments at Qt, just in case.
15 qt_args.extend(args)
16+ # Bug #1018855: Set the WM_CLASS property in X11
17+ if platform.system() not in ['Windows', 'Darwin']:
18+ qt_args.append('OpenLP')
19 # Initialise the resources
20 qInitResources()
21 # Now create and actually run the application.