Merge lp:~mbruzek/charms/trusty/ibm-xl-fortran/readme-update into lp:~ibmcharmers/charms/trusty/ibm-xl-fortran/trunk
Status: | Needs review |
---|---|
Proposed branch: | lp:~mbruzek/charms/trusty/ibm-xl-fortran/readme-update |
Merge into: | lp:~ibmcharmers/charms/trusty/ibm-xl-fortran/trunk |
Diff against target: |
205 lines (+85/-80) 1 file modified
README.md (+85/-80) |
To merge this branch: | bzr merge lp:~mbruzek/charms/trusty/ibm-xl-fortran/readme-update |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
sunitha | Pending | ||
Review via email: mp+276817@code.launchpad.net |
Description of the change
I found the README.md file incomplete and hard to follow.
For example it must be clear this is a Power PC only charm so I added a section near the top that made this very clear.
Also the existing README.md suggested editing the config.yaml file and users can not do that if they deploy this charm from the Charm Store. So I removed that section from the deployment steps.
This merge proposal does not fix all the problems with the README.md file! Some of the configuration uses underscores (_) and some configuration options use hypens (-) as word separators. The code, config.yaml and the README.md should be fixed to normalize on one method.
Please consider this merge proposal.
Unmerged revisions
- 52. By Matt Bruzek
-
Fixing grammer errors in the README update.
- 51. By Matt Bruzek
-
Updating the readme to fix issues that I found in the review.