lp:~mattyw/juju-core/add-environment

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:~go-bot/juju-core/trunk

Juju Engineering: Pending requested 2014-04-03

Diff: 142 lines (+133/-0)

2 files modified

cmd/juju/addenvironment.go (+72/-0)
cmd/juju/addenvironment_test.go (+61/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2536. By Matthew Williams on 2014-04-03

started work on addenvironment command, supports name args and reading yaml from stdin

2535. By Andrew Wilkins on 2014-04-02

[r=axwalk],[bug=1300264] environs/manual: don't require resolvable hostname

This change makes it so that the hostname provided
during manual provisioning is not necessarily
resolvable from the machine provisioning. If this
is the case, the machine will not be given a public
address.

There's another change here, which is that we no
longer perform a reverse lookup or record the
resolved addresses in state; we only store the
input address if it's an IP or if it's a resolvable
hostname. All other addresses will come from the
machine agent itself.

Fixes lp:1300264

https://codereview.appspot.com/82930044/

2534. By Dave Cheney on 2014-04-02

[r=dave-cheney],[bug=1298770] instance.NewAddress now requires an explicit scope

Update LP 1298770

Update instance.NewAddress and all callers to pass an explicit scope. This fixed cases where the Address was bodged after creation. More importantly it has now exposed the dozens of places where an Address is created with scope NetworkUnknown. I hope this makes you as uneasy as I.

https://codereview.appspot.com/82970043/

2533. By Dave Cheney on 2014-04-01

[r=dave-cheney],[bug=1300538] Fixes LP 1300538

Compare the result as a set, not an ordered list. If the results of the watch are supposed to be in order, then the code itself is broken.

https://codereview.appspot.com/83010043/

2532. By Curtis Hovey on 2014-04-01

[r=sinzui] Increment trunk to 1.19.0.

Increment juju and the win installer in the trunk branch to 1.19.0.

https://codereview.appspot.com/83060045/

2531. By Dave Cheney on 2014-04-01

[r=dave-cheney],[bug=1300530] Fixes LP 1300530

Compare the result as a set, not an ordered list. If the results of the watch are supposed to be in order, then the code itself is broken.

https://codereview.appspot.com/83030043/

2530. By Martin Packman on 2014-04-01

[r=jameinel] Fix revid in dependencies.tsv for gomaasapi r48

https://codereview.appspot.com/83060044/

R=rogpeppe

2529. By Horacio Durán on 2014-04-01

[r=gz] provider/maas: Added GetNetworkList

Added GetNetworkList to MAAS Provider, this makes it possible
to obtain a list of networks associated to a given MAAS node.
This branch depends on a change to launchpad.net/gomaasapi
that adds the required capabilities to the TestServer used
in the test suite.

https://codereview.appspot.com/82690043/

R=dimitern

2528. By Roger Peppe on 2014-04-01

[r=rogpeppe] state/api: listen on localhost explicitly

If we listen on ":0", the address returned from Addr
is all-zeros, which is not always valid for dialling localhost.
(I'm not sure why it ever is, actually)

So we listen on 127.0.0.1 explicitly.

https://codereview.appspot.com/83090044/

2527. By Matthew Williams on 2014-04-01

[r=mattyw],[bug=1285256] https://codereview.appspot.com/75600044/

Preliminary support for basic juju id commands:

juju add-user <username> <password>

if password is not supplied a strong one is generated.
The resulting jenv file is output (or saved to a file if -o option is provided)

juju remove-user <username>

doesn't actually remove the user. But mark them as inactive

add-user and remove-user aren't registered yet as they are useless without
login. But the details of this are still being worked out.

This branch also contains fixes for lp:1285256.
The EnvCommandBase struct includes a function for ensuring the envname is not ""