lp:lava-celery
- Get this branch:
- bzr branch lp:lava-celery
Branch merges
Branch information
Recent revisions
- 29. By Andy Doan
-
release 0.4
This should have all the celery changes we need to support fastmodel
workers - 28. By Andy Doan
-
improve exception handling issues
While doing fastmodel testing I encountered some issues:
1) our task loop for dealing with the child process output wasn't handling
all the exceptions that could happen. This leads to difficult debugging.2) our command code for consuming the task messages wasn't handling
exceptions well either making debugging difficult.3) The data coming from the child process in the task code contained
characters the celery serialization code was choking on.I addressed this by adding more exception handling logic into these
loops so that things can continue even if we hit one hiccup during the
execution of a task. I also added our own decode/encode logic which has
an "errors='ignore'" parameter to skip over things we can't handle.The encode/decode logic is probably wrong. My quess is its wrong in two
ways: 1) the decode in the task may need to pick something other than
'utf-8', but I don't know what. 2) the consumer side shouldn't need to
deal with encoding, but the celery serializer (json based by default) seems
to muck with things in a way that's forcing us to something. - 26. By Andy Doan
-
make _exec_command a little safer
This adds some exception handling per mwhudson's review comments to help
ensure we always properly exit the child process.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)