Merge lp:~jose/charms/precise/teamspeak3/1297650-fix into lp:charms/teamspeak3
Proposed by
José Antonio Rey
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 13 | ||||
Proposed branch: | lp:~jose/charms/precise/teamspeak3/1297650-fix | ||||
Merge into: | lp:charms/teamspeak3 | ||||
Diff against target: |
168 lines (+64/-24) 6 files modified
README (+0/-5) README.md (+32/-0) config.yaml (+7/-7) hooks/config-changed (+11/-4) hooks/install (+9/-8) metadata.yaml (+5/-0) |
||||
To merge this branch: | bzr merge lp:~jose/charms/precise/teamspeak3/1297650-fix | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Butler (community) | Approve | ||
charmers | Pending | ||
Review via email: mp+212775@code.launchpad.net |
Commit message
Added categories, icon, reformatted README to Markdown
Description of the change
Charmworld reports the following errors:
err: Charms need a maintainer (See RFC2822) - Name <email>
warn: Metadata is missing categories.
warn: No icon.svg file.
Fixed all of them and reformatted the README to Markdown
To post a comment you must log in.
Thanks for the submission Jose!
While reviewing this merge proposal I have the following notes:
The readme is extremely light on details. There is an opportunity to improve what is here beyond moving the format to markdown. I suggest adding a boilerplate readme via charm-tools 'charm add readme' command and editing the template so you satisfy all the major subsections.
The default admin token to manage the server while grandfathered in also has an opportunity to be changed in default behavior so it's not an open attack vector. If you've got the time to invest in modifying the charm so it is more secure by default that would be a great addition here.
The icon does not conform to charm store guidelines unfortunately and should either be refactored or removed.
barring a few simple modifications, your merge is close to being landed into the charm store. Thanks again for this submission!
I'm going to mark this review as needs fixing, and when you are ready for another review be sure to click the 'request another review' button in the right hand corner.
If you have any questions about this review feel free to contact us in #juju on irc.freenode.net or email the list <email address hidden>
Thanks again!