Juju Charms Collection
newrelic-php package

Merge lp:~jose/charms/precise/newrelic-php/tests-key into lp:~mbruzek/charms/precise/newrelic-php/tests

  1. Precise Pangolin (12.04)
  2. tests-key
  3. Merge into tests
Proposed by José Antonio Rey
Status: Merged
Merged at revision: 15
Proposed branch: lp:~jose/charms/precise/newrelic-php/tests-key
Merge into: lp:~mbruzek/charms/precise/newrelic-php/tests
Diff against target: 11 lines (+1/-0)
1 file modified
tests/99-autogen (+1/-0)
To merge this branch: bzr merge lp:~jose/charms/precise/newrelic-php/tests-key
Reviewer Review Type Date Requested Status
Matt Bruzek Approve
Review via email: mp+245235@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Matt Bruzek (mbruzek) wrote :

Jose,

The tests did not pass for me on LXC. I created a bug against newrelic-php charm with the details.

Since your change did not affect the pass/fail I will accept it, but I think this charm needs a better test, the one I have written is not good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/99-autogen'
2--- tests/99-autogen 2014-11-06 20:43:00 +0000
3+++ tests/99-autogen 2014-12-19 19:29:06 +0000
4@@ -12,6 +12,7 @@
5
6 cls.deployment.add('newrelic-php')
7 cls.deployment.add('wordpress')
8+ cls.deployment.configure('newrelic-php', {'key': '2e2b4406be1e34fe64b228ca7dc16d4ce555add5'})
9 cls.deployment.relate('newrelic-php:juju-info', 'wordpress:juju-info')
10
11 try:

Subscribers

People subscribed via source and target branches

to all changes: