pyjuju

Merge lp:~jorge/pyjuju/add-icons into lp:pyjuju/docs

  1. add-icons
  2. Merge into docs
Proposed by Jorge Castro
Status: Rejected
Rejected by: Jorge Castro
Proposed branch: lp:~jorge/pyjuju/add-icons
Merge into: lp:pyjuju/docs
Diff against target: 11 lines (+1/-0)
1 file modified
source/policy.rst (+1/-0)
To merge this branch: bzr merge lp:~jorge/pyjuju/add-icons
Reviewer Review Type Date Requested Status
Clint Byrum (community) Needs Fixing
Review via email: mp+153439@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Good start, but this doesn't go quite far enough. There should also be something in the charm specification that reserves /icon.svg as an icon to be displayed along with the charm. Also you should require that the icon be valid svg, and perhaps under 1MB in size or something like that.

review: Needs Fixing

Unmerged revisions

91. By Jorge Castro

Add recommendation for icon.svg

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'source/policy.rst'
2--- source/policy.rst 2012-12-14 18:57:18 +0000
3+++ source/policy.rst 2013-03-14 18:37:31 +0000
4@@ -45,6 +45,7 @@
5 * should not use anything infrastructure-provider specific (i.e. querying
6 EC2 metadata service) symlinks must be self contained within a charm.
7 * should make use of `AppArmor <https://juju.ubuntu.com/AppArmor>`_ to increase security
8+* should have an icon.svg in the root of the charm directory for use in the charm store/Juju GUI.
9
10 Terminology
11 -----------

Subscribers

People subscribed via source and target branches

to all changes: