Merge lp:~jorge/charms/precise/postfix/fix-readme into lp:charms/postfix

Proposed by Jorge Castro
Status: Merged
Merged at revision: 17
Proposed branch: lp:~jorge/charms/precise/postfix/fix-readme
Merge into: lp:charms/postfix
Diff against target: 128 lines (+23/-38)
1 file modified
README.md (+23/-38)
To merge this branch: bzr merge lp:~jorge/charms/precise/postfix/fix-readme
Reviewer Review Type Date Requested Status
José Antonio Rey (community) Approve
Review via email: mp+204910@code.launchpad.net
To post a comment you must log in.
Revision history for this message
José Antonio Rey (jose) wrote :

I'm curious about what the difference between # and ## (used in line 110 of the diff) is.

review: Needs Information
Revision history for this message
José Antonio Rey (jose) wrote :

As I expected, it was an h2 tag compared to an h1 tag. Let's go for it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'README' => 'README.md'
2--- README 2014-01-29 17:43:25 +0000
3+++ README.md 2014-02-05 13:34:27 +0000
4@@ -1,5 +1,4 @@
5-Overview
6---------
7+# Overview
8
9 Postfix is Wietse Venema's mail transport agent that started life as an
10 alternative to the widely-used Sendmail program. Postfix attempts to be fast,
11@@ -14,8 +13,7 @@
12 REMINDER: This charm does not include a configuration for a web interface.
13
14
15-Usage
16------
17+# Usage
18
19 To deploy Postfix, you first need to edit the config.yaml with your own
20 configuration options. This is because some certificates will be created once
21@@ -31,36 +29,31 @@
22
23 once the service has finished deploying.
24
25-
26-Configuration
27--------------
28+# Configuration
29
30 To configure the charm, you need to edit the config.yaml file that comes here,
31 setting the values to your current values. More information on the add-ssl and
32 options can be found on the config.yaml file itself.
33
34-hostname: This is the hostname you assigned for the server, not the rDNS
35-
36-domain: This is the domain you will be using for the server (what, in the email
37-address, goes after the @)
38-
39-rootuser: The root username (it is usually root or ubuntu)
40-
41-ssl-key: The SSL key on your system, which should be stated as `cat
42+`hostname`: This is the hostname you assigned for the server, not the rDNS
43+
44+`domain`: This is the domain you will be using for the server (what, in the email address, goes after the @)
45+
46+`rootuser`: The root username (it is usually root or ubuntu)
47+
48+`ssl-key`: The SSL key on your system, which should be stated as `cat
49 ~/smtpd.key`
50
51-ssl-cert: The SSL certificate on your system, which should be stated as `cat
52+`ssl-cert`: The SSL certificate on your system, which should be stated as `cat
53 ~/smtpd.crt`
54
55-cacert: The cacert.pem file you generated on your system, which should be
56+`cacert`: The cacert.pem file you generated on your system, which should be
57 stated as `cat ~/cacert.pem`
58
59-cakey: The cakey.pem file you generated on your system, which should be
60+`cakey`: The cakey.pem file you generated on your system, which should be
61 stated as `cat ~/cakey.pem`
62
63-
64-Adding TLS/SSL support
65-----------------------
66+## Adding TLS/SSL support
67
68 This charm has Transport Socket Layer (TLS) and Secure Socket Layer (SSL)
69 support. Even though this option is not necessary, it is highly recommended. To
70@@ -68,8 +61,7 @@
71 will have to follow the instructions below for generating keys/certificates (in
72 case you do not have them yet) and placing them in the correct directories.
73
74-Generating the keys and certificates
75-------------------------------------
76+## Generating the keys and certificates
77
78 In case you want to add TLS/SSL to this charm you will need to use keys and SSL
79 certificates. If you already have those done, please skip to the bottom of this
80@@ -78,14 +70,11 @@
81 To generate self-signed certificates, you need to issue the following commands
82 on a Terminal:
83
84- touch smtpd.key
85-
86- chmod 600 smtpd.key
87-
88- openssl genrsa 1024 > smtpd.key openssl req -new -key smtpd.key -x509 -days
89+ touch smtpd.key
90+ chmod 600 smtpd.key
91+ openssl genrsa 1024 > smtpd.key openssl req -new -key smtpd.key -x509 -days
92 3650 -out smtpd.crt
93-
94- openssl req -new -x509 -extensions v3_ca -keyout cakey.pem -out cacert.pem
95+ openssl req -new -x509 -extensions v3_ca -keyout cakey.pem -out cacert.pem
96 -days 3650
97
98 Please, note that the third and fourth commands have prompts you have to fill
99@@ -94,25 +83,21 @@
100 Once you have generated the certificates, you can go ahead and execute the
101 following command:
102
103- juju set postfix ssl-key="`cat ~/smtpd.key`" ssl-cert="`cat ~/smtpd.crt`"
104+ juju set postfix ssl-key="`cat ~/smtpd.key`" ssl-cert="`cat ~/smtpd.crt`"
105 cacert="`cat ~/cacert.pem`" cakey="`~/cakey.pem`"
106
107-
108-Renewing the keys and certificates
109-----------------------------------
110+## Renewing the keys and certificates
111
112 The renewal of keys and SSL certificates can be done in the same way that you
113 added SSL support. Just re-run the following command, specifying the new
114 certificates and keys locations instead of the old ones:
115
116- juju set postfix ssl-key="`cat ~/smtpd.key`" ssl-cert="`cat ~/smtpd.crt`"
117+ juju set postfix ssl-key="`cat ~/smtpd.key`" ssl-cert="`cat ~/smtpd.crt`"
118 cacert="`cat ~/cacert.pem`" cakey="`~/cakey.pem`"
119
120 Once you do that, your keys and SSL certificates should be updated.
121
122-
123-Contact Information
124--------------------
125+# Contact Information
126
127 Author: José Antonio Rey <jose@ubuntu.com>
128 Report bugs at: http://bugs.launchpad.net/charms

Subscribers

People subscribed via source and target branches