Merge lp:~jawn-smith/whoopsie/whoopsie into lp:whoopsie

Proposed by William Wilson
Status: Merged
Merged at revision: 718
Proposed branch: lp:~jawn-smith/whoopsie/whoopsie
Merge into: lp:whoopsie
Diff against target: 27 lines (+8/-1)
2 files modified
debian/changelog (+7/-0)
debian/whoopsie.postrm (+1/-1)
To merge this branch: bzr merge lp:~jawn-smith/whoopsie/whoopsie
Reviewer Review Type Date Requested Status
Brian Murray Pending
Review via email: mp+396786@code.launchpad.net

Commit message

Adding force flag to rm call in postrm script

Description of the change

If the file /var/lib/whoopsie/whoopsie-id did not exist, the postrm script would fail. This was seen during the xubuntu minimal install, which is attempting to purge whoopsie in /target after installing. In this scenario, /var/lib/whoopsie/whoopsie-id does not exist yet because whoopsie hasn't started up and therefore hasn't created it's ID file. Adding the force flag to rm will cause it to ignore the missing id file if it is not present.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2021-01-22 21:20:23 +0000
3+++ debian/changelog 2021-01-22 21:40:45 +0000
4@@ -1,3 +1,10 @@
5+whoopsie (0.2.74) hirsute; urgency=medium
6+
7+ * adding force flag to rm command in postrm script in case whoopsie-id
8+ does not yet exist when the package is removed (LP: #1907956)
9+
10+ -- William 'jawn-smith' Wilson <william.wilson@canonical.com> Fri, 22 Jan 2021 15:22:46 -0600
11+
12 whoopsie (0.2.73) hirsute; urgency=medium
13
14 * Attempt to fix double free issue (LP: #1899100)
15
16=== modified file 'debian/whoopsie.postrm'
17--- debian/whoopsie.postrm 2019-02-21 09:33:30 +0000
18+++ debian/whoopsie.postrm 2021-01-22 21:40:45 +0000
19@@ -8,7 +8,7 @@
20 deluser --quiet --system whoopsie > /dev/null || true
21 chmod g-s /var/crash >/dev/null 2>&1
22 chgrp root /var/crash >/dev/null 2>&1
23- rm /var/lib/whoopsie/whoopsie-id >/dev/null
24+ rm -f /var/lib/whoopsie/whoopsie-id >/dev/null
25 fi
26
27 exit 0

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: