Merge lp:~james-page/charms/precise/nova-cloud-controller/nsx-update into lp:~openstack-charmers-archive/charms/precise/nova-cloud-controller/trunk

Proposed by James Page
Status: Merged
Merged at revision: 78
Proposed branch: lp:~james-page/charms/precise/nova-cloud-controller/nsx-update
Merge into: lp:~openstack-charmers-archive/charms/precise/nova-cloud-controller/trunk
Diff against target: 97 lines (+24/-12)
4 files modified
config.yaml (+11/-10)
hooks/nova_cc_context.py (+1/-1)
templates/icehouse/neutron.conf (+1/-1)
templates/icehouse/nsx.ini (+11/-0)
To merge this branch: bzr merge lp:~james-page/charms/precise/nova-cloud-controller/nsx-update
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+223374@code.launchpad.net

Description of the change

Fixup NSX support in Icehouse

To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2014-04-16 08:47:14 +0000
3+++ config.yaml 2014-06-17 10:08:23 +0000
4@@ -69,10 +69,12 @@
5 Quantum plugin to use for network management; supports
6 .
7 ovs - OpenvSwitch Plugin
8- nvp - Nicira Network Virtualization Platform
9+ nvp|nsx - Nicira Network Virtualization Platform/
10+ VMware NSX Network Virtualization Platform
11+ (renamed for Icehouse)
12 .
13 This configuration only has context when used with
14- network-manager Quantum.
15+ network-manager Quantum|Neutron.
16 quantum-security-groups:
17 type: string
18 default: "no"
19@@ -136,18 +138,18 @@
20 default: False
21 description: |
22 If set to True, supporting services will log to syslog.
23- # Neutron NVP Plugin configuration
24+ # Neutron NVP and VMware NSX plugin configuration
25 nvp-controllers:
26 type: string
27- description: Space delimited addresses of NVP controllers
28+ description: Space delimited addresses of NVP/NSX controllers
29 nvp-username:
30 type: string
31 default: admin
32- description: Username to connect to NVP controllers with
33+ description: Username to connect to NVP/NSX controllers with
34 nvp-password:
35 type: string
36 default: admin
37- description: Password to connect to NVP controllers with
38+ description: Password to connect to NVP/NSX controllers with
39 nvp-cluster-name:
40 type: string
41 default: example
42@@ -155,12 +157,11 @@
43 nvp-tz-uuid:
44 type: string
45 description: |
46- This is uuid of the default NVP Transport zone that will be used for
47+ This is uuid of the default NVP/NSX Transport zone that will be used for
48 creating tunneled isolated Quantum networks. It needs to be created
49 in NVP before starting Quantum with the nvp plugin.
50 nvp-l3-uuid:
51 type: string
52 description: |
53- This is uuid of the default NVP L3 Gateway Service.
54- # end of NVP configuration
55-
56+ This is uuid of the default NVP/NSX L3 Gateway Service.
57+ # end of NVP/NSX configuration
58
59=== modified file 'hooks/nova_cc_context.py'
60--- hooks/nova_cc_context.py 2014-04-12 21:25:19 +0000
61+++ hooks/nova_cc_context.py 2014-06-17 10:08:23 +0000
62@@ -161,7 +161,7 @@
63 def __call__(self):
64 ctxt = super(NeutronCCContext, self).__call__()
65 ctxt['external_network'] = config('neutron-external-network')
66- if 'nvp' in [config('quantum-plugin'), config('neutron-plugin')]:
67+ if config('quantum-plugin') in ['nvp', 'nsx']:
68 _config = config()
69 for k, v in _config.iteritems():
70 if k.startswith('nvp'):
71
72=== modified file 'templates/icehouse/neutron.conf'
73--- templates/icehouse/neutron.conf 2014-04-09 07:58:21 +0000
74+++ templates/icehouse/neutron.conf 2014-06-17 10:08:23 +0000
75@@ -68,4 +68,4 @@
76 [service_providers]
77 service_provider=LOADBALANCER:Haproxy:neutron.services.loadbalancer.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default
78 service_provider=VPN:openswan:neutron.services.vpn.service_drivers.ipsec.IPsecVPNDriver:default
79-service_provider=FIREWALL:Iptables:neutron.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver:default
80\ No newline at end of file
81+service_provider=FIREWALL:Iptables:neutron.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver:default
82
83=== added file 'templates/icehouse/nsx.ini'
84--- templates/icehouse/nsx.ini 1970-01-01 00:00:00 +0000
85+++ templates/icehouse/nsx.ini 2014-06-17 10:08:23 +0000
86@@ -0,0 +1,11 @@
87+# icehouse
88+###############################################################################
89+# [ WARNING ]
90+# Configuration file maintained by Juju. Local changes may be overwritten.
91+###############################################################################
92+[DEFAULT]
93+nsx_user = {{ nvp_username }}
94+nsx_password = {{ nvp_password }}
95+nsx_controllers = {{ nvp_controllers }}
96+default_tz_uuid = {{ nvp_tz_uuid }}
97+default_l3_gw_service_uuid = {{ nvp_l3_uuid }}

Subscribers

People subscribed via source and target branches