Merge lp:~ivoks/charms/trusty/neutron-gateway/mtu-vlan into lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next

Proposed by Ante Karamatić
Status: Merged
Merge reported by: James Page
Merged at revision: not available
Proposed branch: lp:~ivoks/charms/trusty/neutron-gateway/mtu-vlan
Merge into: lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next
Diff against target: 26 lines (+7/-1)
1 file modified
hooks/charmhelpers/contrib/openstack/context.py (+7/-1)
To merge this branch: bzr merge lp:~ivoks/charms/trusty/neutron-gateway/mtu-vlan
Reviewer Review Type Date Requested Status
Edward Hope-Morley Needs Fixing
Review via email: mp+271732@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #10303 neutron-gateway-next for ivoks mp271732
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/10303/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #9455 neutron-gateway-next for ivoks mp271732
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9455/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6497 neutron-gateway-next for ivoks mp271732
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12465535/
Build: http://10.245.162.77:8080/job/charm_amulet_test/6497/

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Sorry I should have spotted this before but this change needs to be applied to lp:charm-helpers first (i.e. charmhelpers.contrib.openstack.context) then synced into the charms.

review: Needs Fixing
Revision history for this message
Edward Hope-Morley (hopem) wrote :
Revision history for this message
James Page (james-page) wrote :

Merged under separate cover.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/charmhelpers/contrib/openstack/context.py'
2--- hooks/charmhelpers/contrib/openstack/context.py 2015-09-03 09:43:15 +0000
3+++ hooks/charmhelpers/contrib/openstack/context.py 2015-09-19 08:49:20 +0000
4@@ -20,6 +20,7 @@
5 import time
6 from base64 import b64decode
7 from subprocess import check_call
8+from glob import glob
9
10 import six
11 import yaml
12@@ -1334,8 +1335,13 @@
13 ports = mappings.values()
14 napi_settings = NeutronAPIContext()()
15 mtu = napi_settings.get('network_device_mtu')
16+ all_ports = []
17+ for port in ports:
18+ for lport in glob("/sys/class/net/%s/lower_*" % port):
19+ all_ports.append(lport.split('_')[1])
20+ all_ports.extend(ports)
21 if mtu:
22- ctxt["devs"] = '\\n'.join(ports)
23+ ctxt["devs"] = '\\n'.join(all_ports)
24 ctxt['mtu'] = mtu
25
26 return ctxt

Subscribers

People subscribed via source and target branches