Merge lp:~hopem/charms/precise/ceph/lp1259919 into lp:~charmers/charms/precise/ceph/trunk

Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 68
Proposed branch: lp:~hopem/charms/precise/ceph/lp1259919
Merge into: lp:~charmers/charms/precise/ceph/trunk
Diff against target: 53 lines (+15/-3)
4 files modified
config.yaml (+11/-0)
hooks/hooks.py (+2/-1)
revision (+1/-1)
templates/ceph.conf (+1/-1)
To merge this branch: bzr merge lp:~hopem/charms/precise/ceph/lp1259919
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+198705@code.launchpad.net
To post a comment you must log in.
Revision history for this message
James Page (james-page) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2013-08-27 10:44:50 +0000
3+++ config.yaml 2013-12-12 11:18:46 +0000
4@@ -49,6 +49,17 @@
5 no journal device will be used.
6 .
7 Only supported with ceph >= 0.48.3.
8+ osd-journal-size:
9+ type: int
10+ default: 1024
11+ description: |
12+ Ceph osd journal size. The journal size should be at least twice the
13+ product of the expected drive speed multiplied by filestore max sync
14+ interval. However, the most common practice is to partition the journal
15+ drive (often an SSD), and mount it such that Ceph uses the entire
16+ partition for the journal.
17+ .
18+ Only supported with ceph >= 0.48.3.
19 osd-format:
20 type: string
21 default: xfs
22
23=== modified file 'hooks/hooks.py'
24--- hooks/hooks.py 2013-11-18 12:20:21 +0000
25+++ hooks/hooks.py 2013-12-12 11:18:46 +0000
26@@ -71,7 +71,8 @@
27 'auth_supported': config('auth-supported'),
28 'mon_hosts': ' '.join(get_mon_hosts()),
29 'fsid': config('fsid'),
30- 'version': ceph.get_ceph_version()
31+ 'version': ceph.get_ceph_version(),
32+ 'osd_journal_size': config('osd-journal-size')
33 }
34 # Install ceph.conf as an alternative to support
35 # co-existence with other charms that write this file
36
37=== modified file 'revision'
38--- revision 2013-10-10 10:46:24 +0000
39+++ revision 2013-12-12 11:18:46 +0000
40@@ -1,1 +1,1 @@
41-103
42+104
43
44=== modified file 'templates/ceph.conf'
45--- templates/ceph.conf 2012-12-17 10:22:51 +0000
46+++ templates/ceph.conf 2013-12-12 11:18:46 +0000
47@@ -18,6 +18,6 @@
48
49 [osd]
50 keyring = /var/lib/ceph/osd/$cluster-$id/keyring
51- osd journal size = 1000
52+ osd journal size = {{ osd_journal_size }}
53 filestore xattr use omap = true
54

Subscribers

People subscribed via source and target branches