lp:~hatch/juju-gui/bundle-detail-view
- Get this branch:
- bzr branch lp:~hatch/juju-gui/bundle-detail-view
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 1749 lines (+855/-797)7 files modifiedapp/modules-debug.js (+1/-1)
app/store/charm.js (+0/-769)
app/store/charmworld.js (+798/-0)
app/subapps/browser/browser.js (+1/-2)
app/subapps/browser/views/charm.js (+53/-19)
app/templates/bundle.handlebars (+2/-2)
undocumented (+0/-4)
Branch information
Recent revisions
- 1097. By Francesco Banconi
-
Units and constraints handling in subordinates.
Improve how unit scaling and constraint options are
handled in the ghost and deployed inspectors when a
service is deployed from a subordinate charm.Also fixed a bug in the units count preventing
subordinates to be deployed in a juju-core
sandbox/real environment.QA:
- make devel/debug;
- deploy a principal charm, both the ghost
inspector and the deployed inspector
include unit scaling and constraints,
everything works as expected;
- deploy a subordinate charm (e.g. puppet),
inspectors don't show unit scaling and
constraints, everything works as expected.R=jeff.pihach
CC=
https://codereview. appspot. com/14125043 - 1096. By Jeff Pihach
-
Close inspector when service is destroyed
The inspector was never hooked up to react to services
being removed via the delta and were left in the canvas.
This branch has the inspector listen for the service model
switching to a dying state and then destroying the inspector
and the service menu.R=frankban, gary.poster
CC=
https://codereview. appspot. com/13938043 - 1095. By Benji York
-
Assure bundles can be displayed in search results.
R=bac
CC=
https://codereview. appspot. com/14031045 - 1094. By Huw Wilkins
-
Added bundle token HTML shell
This branch adds content to the bundle token, some of which is just dummy placement content.
There is also a drive-by fix for the charm details panel header content not being spaced correctly.
R=gary.poster
CC=
https://codereview. appspot. com/14011045 - 1093. By Benjamin Saller
-
Remove DB.units list
This branch is a monster. Apologies in advance.
This removes the db.units list and makes the GUI only use service.
get('units' )
for service specific unit lists. Outside of the simulator we only ever look
at units in the context of a service and keeping two copies of things was
silly. This works better with the databinding code and is a pattern we intend
to move forward with (wrt to relations I expect we'll get rid of the global
list as well).There was however a fair bit of code that touched units which lead to a number
of minor changes. Then I realized I was fixing some code in deprecated views
so I went through and did a first pass at removing dead code related to the
old views.Also there are changes to the test server to run on a random port which should
allow safely running make check/lbox w/o getting the test server from another
branch.R=benjamin.saller, jeff.pihach, gary.poster
CC=
https://codereview. appspot. com/13997043 - 1092. By Brad Crittenden
-
Move resultsToCharmlist to transformResults.
In APIv3 support bundles and return an array of charm and bundle objects.
R=benji
CC=
https://codereview. appspot. com/14036044
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:juju-gui/experimental