Merge lp:~gnuoy/charms/trusty/nova-compute/1427660 into lp:~openstack-charmers-archive/charms/trusty/nova-compute/next

Proposed by Liam Young
Status: Merged
Merged at revision: 113
Proposed branch: lp:~gnuoy/charms/trusty/nova-compute/1427660
Merge into: lp:~openstack-charmers-archive/charms/trusty/nova-compute/next
Diff against target: 40 lines (+5/-0)
2 files modified
hooks/nova_compute_hooks.py (+3/-0)
unit_tests/test_nova_compute_hooks.py (+2/-0)
To merge this branch: bzr merge lp:~gnuoy/charms/trusty/nova-compute/1427660
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+251596@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2398 nova-compute-next for gnuoy mp251596
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2398/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #2188 nova-compute-next for gnuoy mp251596
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/2188/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #2318 nova-compute-next for gnuoy mp251596
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/2318/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/nova_compute_hooks.py'
2--- hooks/nova_compute_hooks.py 2015-02-06 18:09:18 +0000
3+++ hooks/nova_compute_hooks.py 2015-03-03 13:38:04 +0000
4@@ -17,6 +17,7 @@
5 )
6 from charmhelpers.core.host import (
7 restart_on_change,
8+ service_restart,
9 )
10
11 from charmhelpers.fetch import (
12@@ -235,6 +236,8 @@
13 @restart_on_change(restart_map())
14 def ceph_joined():
15 apt_install(filter_installed_packages(['ceph-common']), fatal=True)
16+ # Bug 1427660
17+ service_restart('libvirt-bin')
18
19
20 @hooks.hook('ceph-relation-changed')
21
22=== modified file 'unit_tests/test_nova_compute_hooks.py'
23--- unit_tests/test_nova_compute_hooks.py 2015-01-09 15:40:46 +0000
24+++ unit_tests/test_nova_compute_hooks.py 2015-03-03 13:38:04 +0000
25@@ -27,6 +27,7 @@
26 'apt_update',
27 'filter_installed_packages',
28 'restart_on_change',
29+ 'service_restart',
30 # charmhelpers.contrib.openstack.utils
31 'configure_installation_source',
32 'openstack_upgrade_available',
33@@ -342,6 +343,7 @@
34 def test_ceph_joined(self):
35 hooks.ceph_joined()
36 self.apt_install.assert_called_with(['ceph-common'], fatal=True)
37+ self.service_restart.assert_called_with('libvirt-bin')
38
39 @patch.object(hooks, 'CONFIGS')
40 def test_ceph_changed_missing_relation_data(self, configs):

Subscribers

People subscribed via source and target branches