Merge lp:~evarlast/charms/trusty/juju-gui/nrpe-check-update into lp:charms/trusty/juju-gui

Proposed by Jay R. Wren
Status: Merged
Merge reported by: Jay R. Wren
Merged at revision: not available
Proposed branch: lp:~evarlast/charms/trusty/juju-gui/nrpe-check-update
Merge into: lp:charms/trusty/juju-gui
Diff against target: 20 lines (+2/-8)
1 file modified
files/nrpe-external-master/check-app-access.sh (+2/-8)
To merge this branch: bzr merge lp:~evarlast/charms/trusty/juju-gui/nrpe-check-update
Reviewer Review Type Date Requested Status
Martin Hilton (community) Approve
Madison Scott-Clary (community) code Approve
Review via email: mp+271560@code.launchpad.net

Description of the change

When the legacy server was removed the nrpe check was never updated to match.

Ideally this check out use the configured port, but in practice the demo deployment is only thing which uses this and it runs on port 80.

To post a comment you must log in.
Revision history for this message
Madison Scott-Clary (makyo) wrote :

LGTM, much simpler.

review: Approve (code)
Revision history for this message
Martin Hilton (martin-hilton) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'files/nrpe-external-master/check-app-access.sh'
2--- files/nrpe-external-master/check-app-access.sh 2014-02-18 12:18:02 +0000
3+++ files/nrpe-external-master/check-app-access.sh 2015-09-17 21:02:32 +0000
4@@ -1,14 +1,8 @@
5 #!/bin/bash
6-SITE_CONF='/etc/apache2/sites-enabled/juju-gui'
7-ADDRESS='https://127.0.0.1:443/juju-ui/version.js'
8+ADDRESS='http://127.0.0.1/juju-ui/version.js'
9 LIFE_SIGN='jujuGuiVersionInfo'
10
11-if [[ ! -f $SITE_CONF ]]; then
12- echo Apache is not configured serve juju-gui.
13- exit 2
14-fi
15-
16-match=$(curl -s -k $ADDRESS | grep "$LIFE_SIGN")
17+match=$(curl -s $ADDRESS | grep "$LIFE_SIGN")
18
19 if [[ -z $match ]]; then
20 echo juju-gui did not return content indicating it was loading.

Subscribers

People subscribed via source and target branches