Merge lp:~evarlast/charms/precise/varnish/hyphen-to-underscore into lp:charms/varnish

Proposed by Jay R. Wren
Status: Merged
Merged at revision: 13
Proposed branch: lp:~evarlast/charms/precise/varnish/hyphen-to-underscore
Merge into: lp:charms/varnish
Diff against target: 21 lines (+2/-2)
1 file modified
hooks/reverseproxy-relation-changed (+2/-2)
To merge this branch: bzr merge lp:~evarlast/charms/precise/varnish/hyphen-to-underscore
Reviewer Review Type Date Requested Status
Charles Butler (community) Approve
Tim Van Steenburgh (community) Approve
Review via email: mp+226734@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

+1 LGTM.

review: Approve
Revision history for this message
Charles Butler (lazypower) wrote :

Great fix, merging. Thanks for the submission Jay!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/reverseproxy-relation-changed'
2--- hooks/reverseproxy-relation-changed 2012-06-22 17:03:03 +0000
3+++ hooks/reverseproxy-relation-changed 2014-07-14 19:26:32 +0000
4@@ -23,7 +23,7 @@
5 unit_port=`relation-get port $member`
6 unit_addr=`relation-get hostname $member`
7 # replace / in the member name to produce a valid varnish service name
8- unit_name=${member//\//}
9+unit_name=$(echo ${member//\//} | tr - _)
10 cat >> /etc/varnish/default.vcl << EOF
11 backend $unit_name {
12 .host = "${unit_addr}";
13@@ -44,7 +44,7 @@
14 echo 'director balance round-robin {' >> /etc/varnish/default.vcl
15
16 for member in $members; do
17- unit_name=${member//\//}
18+ unit_name=$(echo ${member//\//} | tr - _)
19 cat >> /etc/varnish/default.vcl << EOF
20 { .backend = $unit_name; }
21 EOF

Subscribers

People subscribed via source and target branches

to all changes: