Merge lp:~brian-murray/arsenal/length-in-state into lp:~bryce/arsenal/2.x

[Brian Murray]

This branch adds in a days-in-state search criteria which uses the filter_status_length from lpltk bzr revno 160. This allows you to do something like search for bugs assigned to the Canonical Foundations team with a status of In Progress and in that state for more than 30 days - kinda neat.

Additionally, when testing this I noticed that I was only getting tasks assigned to one team member because I was returning after the first participant was done. I've fixed this by creating a list of assigned tasks and returning that once all the participants have been iterated through.

[Bryce Harrington (bryce)]

review: Approve

=== modified file 'scripts/collect-bug-data'
--- scripts/collect-bug-data	2012-07-03 20:07:11 +0000
+++ scripts/collect-bug-data	2012-07-10 16:21:25 +0000
@@ -338,7 +338,12 @@
             reopened = search_criteria['reopened']
         except KeyError:
             reopened = False
-        
+
+        try:
+            statuslength = search_criteria['days-in-state']
+        except KeyError:
+            statuslength = False
+
         # ensure that only one of these are selected
         count = 0
         if search_assignees != '':
@@ -361,7 +366,7 @@
                 'order_by': search_order}
 
         if search_reporters != '':
-            tasks = []
+            reported_tasks = []
             for reporter in search_reporters:
                 search_reporter = self.lp.launchpad.people[reporter]
                 if search_reporter.is_team is False:
@@ -369,6 +374,9 @@
                     tasks = distro.search_tasks(**search_args)
                     if reopened:
                         tasks.set_filter_reopened()
+                    if statuslength:
+                        tasks.set_filter_status_length(statuslength)
+                    reported_tasks.append(tasks)
                 else:
                     for participant in search_reporter.participants:
                         if participant.is_team:
@@ -377,12 +385,16 @@
                         tasks = distro.search_tasks(**search_args)
                         if reopened:
                             tasks.set_filter_reopened()
+                        if statuslength:
+                            tasks.set_filter_status_length(statuslength)
+                        for task in tasks:
+                            reported_tasks.append(task)
                 if search_limit:
-                    return tasks[:search_limit]
+                    return reported_tasks[:search_limit]
                 else:
-                    return tasks
+                    return reported_tasks
         if search_assignees != '':
-            tasks = []
+            assigned_tasks = []
             for assignee in search_assignees:
                 search_assignee = self.lp.launchpad.people[assignee]
                 if search_assignee.is_team is False:
@@ -390,6 +402,9 @@
                     tasks = distro.search_tasks(**search_args)
                     if reopened:
                         tasks.set_filter_reopened()
+                    if statuslength:
+                        tasks.set_filter_status_length(statuslength)
+                    assigned_tasks.append(tasks)
                     search_assignee_names.append(search_assignee.name)
                 else:
                     for participant in search_assignee.participants:
@@ -399,10 +414,14 @@
                         tasks = distro.search_tasks(**search_args)
                         if reopened:
                             tasks.set_filter_reopened()
+                        if statuslength:
+                            tasks.set_filter_status_length(statuslength)
+                        for task in tasks:
+                            assigned_tasks.append(task)
                 if search_limit:
-                    return tasks[:search_limit]
+                    return assigned_tasks[:search_limit]
                 else:
-                    return tasks
+                    return assigned_tasks
         # Subscribers searches differently than assignee, participant.
         # TODO: consolidate searching by these fields and make the splitting team
         # into participants a configurable feature.
@@ -413,6 +432,8 @@
                 tasks = distro.search_tasks(**search_args)
                 if reopened:
                     tasks.set_filter_reopened()
+                if statuslength:
+                    tasks.set_filter_status_length(statuslength)
                 if search_limit:
                     return tasks[:search_limit]
                 else:
@@ -421,6 +442,8 @@
             tasks = distro.search_tasks(**search_args)
             if reopened:
                 tasks.set_filter_reopened()
+            if statuslength:
+                tasks.set_filter_status_length(statuslength)
             if search_limit:
                 return tasks[:search_limit]
             else: