arsenal

Merge lp:~brad-figg/arsenal/quantal-filter-fix into lp:~bryce/arsenal/2.x

  1. quantal-filter-fix
  2. Merge into 2.x
Proposed by Brad Figg
Status: Merged
Approved by: Bryce Harrington
Approved revision: 1061
Merge reported by: Bryce Harrington
Merged at revision: not available
Proposed branch: lp:~brad-figg/arsenal/quantal-filter-fix
Merge into: lp:~bryce/arsenal/2.x
Diff against target: 47 lines (+4/-0)
4 files modified
web/templates/bugs-by-assignee.mako (+1/-0)
web/templates/bugs-by-hwe-project.mako (+1/-0)
web/templates/bugs-by-team-dupe-count.mako (+1/-0)
web/templates/bugs-by-team.mako (+1/-0)
To merge this branch: bzr merge lp:~brad-figg/arsenal/quantal-filter-fix
Reviewer Review Type Date Requested Status
Bryce Harrington code Approve
Review via email: mp+108623@code.launchpad.net

Description of the change

The dropdown "options" list contains the names of the series that can be searched for. This list is hardcoded into the templates. This list is used for filtering out bugs by series and if a series is not in the list it will be filtered out.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) :
review: Approve (code)
Revision history for this message
Bryce Harrington (bryce) wrote :

Pushed. This looks worth including in the stable branch, so might point ursula at the branch as well.

Revision history for this message
Brad Figg (brad-figg) wrote :

I thought "trunk" was stable and since this was a branch from trunk the merge request was for trunk. Did I misunderstand something?

Revision history for this message
Bryce Harrington (bryce) wrote :

Right, see https://lists.launchpad.net/arsenal-user/msg00001.html for a summary of the branch changes.

Short story is that lp:arsenal/trunk still exists, but lp:arsenal/1.x is the stable tree now, and lp:arsenal is pointed to the development tree.

Btw, I'd love your feedback on some of the other proposals I posted to arsenal-user@; I figure I'll be pulling the trigger on those before too long.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'web/templates/bugs-by-assignee.mako'
2--- web/templates/bugs-by-assignee.mako 2012-03-27 00:11:30 +0000
3+++ web/templates/bugs-by-assignee.mako 2012-06-04 20:09:19 +0000
4@@ -109,6 +109,7 @@
5 <td valign="top" width="30%">
6 <p class="l2-section-heading">Series</p>
7 <table width="100%">
8+ <tr><td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="quantal" /> Quantal </td></tr>
9 <tr><td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="precise" /> Precise </td>
10 <td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="jaunty" /> Jaunty </td></tr>
11 <tr><td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="oneiric" /> Oneiric </td>
12
13=== modified file 'web/templates/bugs-by-hwe-project.mako'
14--- web/templates/bugs-by-hwe-project.mako 2012-03-27 00:11:30 +0000
15+++ web/templates/bugs-by-hwe-project.mako 2012-06-04 20:09:19 +0000
16@@ -109,6 +109,7 @@
17 <td valign="top" width="30%">
18 <p class="l2-section-heading">Series</p>
19 <table width="100%">
20+ <tr><td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="quantal" /> Quantal </td></tr>
21 <tr><td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="precise" /> Precise </td>
22 <td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="jaunty" /> Jaunty </td></tr>
23 <tr><td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="oneiric" /> Oneiric </td>
24
25=== modified file 'web/templates/bugs-by-team-dupe-count.mako'
26--- web/templates/bugs-by-team-dupe-count.mako 2012-05-16 22:38:27 +0000
27+++ web/templates/bugs-by-team-dupe-count.mako 2012-06-04 20:09:19 +0000
28@@ -111,6 +111,7 @@
29 <td valign="top" width="30%">
30 <p class="l2-section-heading">Series</p>
31 <table width="100%">
32+ <tr><td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="quantal" /> Quantal </td></tr>
33 <tr><td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="precise" /> Precise </td>
34 <td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="jaunty" /> Jaunty </td></tr>
35 <tr><td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="oneiric" /> Oneiric </td>
36
37=== modified file 'web/templates/bugs-by-team.mako'
38--- web/templates/bugs-by-team.mako 2012-04-11 23:37:23 +0000
39+++ web/templates/bugs-by-team.mako 2012-06-04 20:09:19 +0000
40@@ -111,6 +111,7 @@
41 <td valign="top" width="30%">
42 <p class="l2-section-heading">Series</p>
43 <table width="100%">
44+ <tr><td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="quantal" /> Quantal </td></tr>
45 <tr><td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="precise" /> Precise </td>
46 <td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="jaunty" /> Jaunty </td></tr>
47 <tr><td width="50%"> <input type="checkbox" name="series" onclick="series_handler(this, 'series', true)" checked value="oneiric" /> Oneiric </td>

Subscribers

People subscribed via source and target branches