Merge lp:~bigdata-dev/charms/bundles/apache-core-batch-processing/staging into lp:~charmers/charms/bundles/apache-core-batch-processing/bundle

Proposed by Cory Johns
Status: Merged
Merged at revision: 16
Proposed branch: lp:~bigdata-dev/charms/bundles/apache-core-batch-processing/staging
Merge into: lp:~charmers/charms/bundles/apache-core-batch-processing/bundle
Diff against target: 135 lines (+58/-12)
3 files modified
bundle.yaml (+4/-4)
bundles_v3.yaml (+50/-0)
tests/01-bundle.py (+4/-8)
To merge this branch: bzr merge lp:~bigdata-dev/charms/bundles/apache-core-batch-processing/staging
Reviewer Review Type Date Requested Status
Kevin W Monroe Approve
amir sanjar (community) Approve
charmers Pending
Review via email: mp+265338@code.launchpad.net

Description of the change

Bundle and test tweaks for Cloud Weather Report.

To post a comment you must log in.
16. By Cory Johns

Fixed v3 format bundle pointing at wrong charms

Revision history for this message
amir sanjar (asanjar) wrote :

+1

review: Approve
Revision history for this message
Kevin W Monroe (kwmonroe) wrote :

+1 LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bundle.yaml'
2--- bundle.yaml 2015-06-17 15:21:59 +0000
3+++ bundle.yaml 2015-07-21 14:15:53 +0000
4@@ -11,14 +11,14 @@
5 annotations:
6 gui-x: "250"
7 gui-y: "200"
8- constraints: mem=4G
9+ constraints: mem=3G
10 hdfs-master:
11 charm: cs:trusty/apache-hadoop-hdfs-master
12 num_units: 1
13 annotations:
14 gui-x: "600"
15 gui-y: "350"
16- constraints: mem=8G
17+ constraints: mem=7G
18 plugin:
19 charm: cs:trusty/apache-hadoop-plugin
20 annotations:
21@@ -30,14 +30,14 @@
22 annotations:
23 gui-x: "600"
24 gui-y: "600"
25- constraints: mem=8G
26+ constraints: mem=7G
27 yarn-master:
28 charm: cs:trusty/apache-hadoop-yarn-master
29 num_units: 1
30 annotations:
31 gui-x: "600"
32 gui-y: "100"
33- constraints: mem=8G
34+ constraints: mem=7G
35 series: trusty
36 relations:
37 - [yarn-master, hdfs-master]
38
39=== added file 'bundles_v3.yaml'
40--- bundles_v3.yaml 1970-01-01 00:00:00 +0000
41+++ bundles_v3.yaml 2015-07-21 14:15:53 +0000
42@@ -0,0 +1,50 @@
43+bundle:
44+ services:
45+ client:
46+ charm: cs:trusty/apache-hadoop-client
47+ num_units: 1
48+ annotations:
49+ gui-x: "1300"
50+ gui-y: "200"
51+ compute-slave:
52+ charm: cs:trusty/apache-hadoop-compute-slave
53+ num_units: 3
54+ annotations:
55+ gui-x: "250"
56+ gui-y: "200"
57+ constraints: mem=3G
58+ hdfs-master:
59+ charm: cs:trusty/apache-hadoop-hdfs-master
60+ num_units: 1
61+ annotations:
62+ gui-x: "600"
63+ gui-y: "350"
64+ constraints: mem=7G
65+ plugin:
66+ charm: cs:trusty/apache-hadoop-plugin
67+ annotations:
68+ gui-x: "950"
69+ gui-y: "200"
70+ secondary-namenode:
71+ charm: cs:trusty/apache-hadoop-hdfs-secondary
72+ num_units: 1
73+ annotations:
74+ gui-x: "600"
75+ gui-y: "600"
76+ constraints: mem=7G
77+ yarn-master:
78+ charm: cs:trusty/apache-hadoop-yarn-master
79+ num_units: 1
80+ annotations:
81+ gui-x: "600"
82+ gui-y: "100"
83+ constraints: mem=7G
84+ series: trusty
85+ relations:
86+ - [yarn-master, hdfs-master]
87+ - [secondary-namenode, hdfs-master]
88+ - [compute-slave, yarn-master]
89+ - [compute-slave, hdfs-master]
90+ - [plugin, yarn-master]
91+ - [plugin, hdfs-master]
92+ - [client, plugin]
93
94=== modified file 'tests/01-bundle.py'
95--- tests/01-bundle.py 2015-06-01 15:03:04 +0000
96+++ tests/01-bundle.py 2015-07-21 14:15:53 +0000
97@@ -12,7 +12,8 @@
98 """
99 Base class for tests for Apache Hadoop Bundle.
100 """
101- bundle_file = os.path.join(os.path.dirname(__file__), '..', 'bundle.yaml')
102+ # have to use the v3 format because that's what amulet supports
103+ bundle_file = os.path.join(os.path.dirname(__file__), '..', 'bundles_v3.yaml')
104 profile_name = None
105
106 @classmethod
107@@ -22,17 +23,14 @@
108 cls.d = amulet.Deployment(series='trusty')
109 with open(cls.bundle_file) as f:
110 bun = f.read()
111- profiles = yaml.safe_load(bun)
112- # amulet always selects the first profile, so we have to fudge it here
113- profile = {cls.profile_name: profiles[cls.profile_name]}
114- cls.d.load(profile)
115+ bundle = yaml.safe_load(bun)
116+ cls.d.load(bundle)
117 cls.d.setup(timeout=9000)
118 cls.d.sentry.wait()
119 cls.hdfs = cls.d.sentry.unit['hdfs-master/0']
120 cls.yarn = cls.d.sentry.unit['yarn-master/0']
121 cls.slave = cls.d.sentry.unit['compute-slave/0']
122 cls.secondary = cls.d.sentry.unit['secondary-namenode/0']
123- cls.plugin = cls.d.sentry.unit['plugin/0']
124 cls.client = cls.d.sentry.unit['client/0']
125
126 @classmethod
127@@ -117,8 +115,6 @@
128
129
130 class TestScalable(unittest.TestCase, Base):
131- profile_name = 'apache-core-batch-processing'
132-
133 @classmethod
134 def setUpClass(cls):
135 cls.deploy()

Subscribers

People subscribed via source and target branches