Merge lp:~benji/landscape-client/try-unicode into lp:~landscape/landscape-client/trunk
Proposed by
Benji York
Status: | Rejected |
---|---|
Rejected by: | Benji York |
Proposed branch: | lp:~benji/landscape-client/try-unicode |
Merge into: | lp:~landscape/landscape-client/trunk |
Diff against target: |
255 lines (+49/-13) 18 files modified
landscape/log.py (+3/-0) landscape/manager/aptsources.py (+2/-0) landscape/manager/config.py (+2/-0) landscape/manager/customgraph.py (+13/-9) landscape/manager/fakepackagemanager.py (+2/-0) landscape/manager/hardwareinfo.py (+2/-0) landscape/manager/haservice.py (+2/-0) landscape/manager/keystonetoken.py (+2/-0) landscape/manager/manager.py (+2/-0) landscape/manager/packagemanager.py (+2/-0) landscape/manager/plugin.py (+2/-0) landscape/manager/processkiller.py (+2/-0) landscape/manager/scriptexecution.py (+2/-2) landscape/manager/service.py (+2/-0) landscape/manager/shutdownmanager.py (+2/-0) landscape/manager/store.py (+4/-1) landscape/manager/tests/test_usermanager.py (+1/-1) landscape/manager/usermanager.py (+2/-0) |
To merge this branch: | bzr merge lp:~benji/landscape-client/try-unicode |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Adam Collard (community) | Disapprove | ||
Chad Smith | Pending | ||
Review via email: mp+296360@code.launchpad.net |
Description of the change
This branch begins chipping away at converting the client codebase to
using unicode and byte strings so as to be compatible with Python 3.
This branch converts all of the modules in the landscape/managers
directory. Many survived with only a one-line change to add a from
__future__ import, but others required more work.
Testing instructions:
make check
start the client and register it
To post a comment you must log in.
Unmerged revisions
- 844. By Benji York
-
fix lint
- 843. By Benji York
-
checkpoint - tests passing
- 842. By Benji York
-
checkpoint - tests passing
- 841. By Benji York
-
checkpoint - tests passing
Hmm, toggling unicode_literals feels a bit dangerous.
There is some discussion about the pro's and con's at http:// python- future. org/unicode_ literals. html .
Can we put some words on paper (read: Google doc) as to why we took this approach, what the risks are etc.? Just make the case for unicode_literals as opposed to string-by-string u"" or b""