Merge lp:~benji/juju-core/1130173 into lp:~juju/juju-core/trunk
Proposed by
Benji York
Status: | Merged | ||||
---|---|---|---|---|---|
Merge reported by: | Benji York | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~benji/juju-core/1130173 | ||||
Merge into: | lp:~juju/juju-core/trunk | ||||
Diff against target: | 0 lines | ||||
To merge this branch: | bzr merge lp:~benji/juju-core/1130173 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
The Go Language Gophers | Pending | ||
Review via email: mp+151555@code.launchpad.net |
Description of the change
Add Resolved to the API
To post a comment you must log in.
Overall LGTM, just some trivials.
https:/ /codereview. appspot. com/7460047/ diff/1/ state/api/ api_test. go api_test. go (right):
File state/api/
https:/ /codereview. appspot. com/7460047/ diff/1/ state/api/ api_test. go#newcode269 api_test. go:269: if err != nil && err.Error() == "permission
state/api/
denied" {
instead of err.Error() == "permission denied", can you use like
ErrPermDenied and compare to that? Or having a helper func
IsPermDenied(taking an error)?
https:/ /codereview. appspot. com/7460047/ diff/1/ state/api/ api_test. go#newcode276 api_test. go:276: c.Assert(err, Not(IsNil)) /NotNil/
state/api/
s/Not(IsNil)
https:/ /codereview. appspot. com/7460047/ diff/1/ state/api/ api_test. go#newcode277 api_test. go:277: c.Assert( err.Error( ), Equals, "unit
state/api/
\"wordpress/0\" is not in an error state")
`unit "wordpress/0" is not in an error state`
https:/ /codereview. appspot. com/7460047/ diff/1/ state/statecmd/ resolved. go resolved. go (right):
File state/statecmd/
https:/ /codereview. appspot. com/7460047/ diff/1/ state/statecmd/ resolved. go#newcode22 resolved. go:22: // reexecute previous failed hooks or to
state/statecmd/
continue as if they had succeeded
s/reexecute/retry/
https:/ /codereview. appspot. com/7460047/ diff/1/ state/statecmd/ resolved_ test.go resolved_ test.go (right):
File state/statecmd/
https:/ /codereview. appspot. com/7460047/ diff/1/ state/statecmd/ resolved_ test.go# newcode12 resolved_ test.go: 12: //stdtesting "testing"
state/statecmd/
d
https:/ /codereview. appspot. com/7460047/