Merge lp:~benji/charms/precise/juju-gui/make-etags-ignore-inode into lp:~juju-gui/charms/precise/juju-gui/trunk

[Benji York]

Ignore inodes when generating etags.

Since the inode for a given file will vary across servers, using inode to
generate etags when there are multiple back-end servers means that the etags
for a given URL will vary depending on which back-end fulfilled the request.

https://codereview.appspot.com/55210044/

[Benji York (benji)]

Reviewers: mp+202542_code.launchpad.net,

Message:
Please take a look.

Description:
Ignore inodes when generating etags.

Since the inode for a given file will vary across servers, using inode
to
generate etags when there are multiple back-end servers means that the
etags
for a given URL will vary depending on which back-end fulfilled the
request.

https://code.launchpad.net/~benji/charms/precise/juju-gui/make-etags-ignore-inode/+merge/202542

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/55210044/

Affected files (+4, -0 lines):
   A [revision details]
   M config/apache-site.template

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: config/apache-site.template
=== modified file 'config/apache-site.template'
--- config/apache-site.template 2013-08-09 13:26:54 +0000
+++ config/apache-site.template 2014-01-21 19:48:07 +0000
@@ -3,10 +3,12 @@

   DocumentRoot {{server_root}}
   <Directory />
+ FileETag MTime Size
    Options FollowSymLinks
    AllowOverride None
   </Directory>
   <Directory {{server_root}}>
+ FileETag MTime Size
    Options Indexes FollowSymLinks MultiViews
    AllowOverride None
    Order allow,deny

[Benji York (benji)]

LGTMMAI (looks good to me, myself, and I)

https://codereview.appspot.com/55210044/

[Benji York (benji)]

*** Submitted:

Ignore inodes when generating etags.

Since the inode for a given file will vary across servers, using inode
to
generate etags when there are multiple back-end servers means that the
etags
for a given URL will vary depending on which back-end fulfilled the
request.

R=benji-york
CC=
https://codereview.appspot.com/55210044

https://codereview.appspot.com/55210044/

=== modified file 'config/apache-site.template'
--- config/apache-site.template	2013-08-09 13:26:54 +0000
+++ config/apache-site.template	2014-01-21 19:52:23 +0000
@@ -3,10 +3,12 @@
 
 	DocumentRoot {{server_root}}
 	<Directory />
+		FileETag MTime Size
 		Options FollowSymLinks
 		AllowOverride None
 	</Directory>
 	<Directory {{server_root}}>
+		FileETag MTime Size
 		Options Indexes FollowSymLinks MultiViews
 		AllowOverride None
 		Order allow,deny