Merge lp:~bbaqar/charms/trusty/plumgrid-edge/opsvm into lp:~plumgrid-team/charms/trusty/plumgrid-edge/trunk

[Bilal Baqar]

OPSVM Changes
Ticket: [SOL-830]

- Getting OPSVM IP from director relation
- Making OPSVM specific changes
- Cleaned code in various functions
- Added restart_on_change decorater function that restarts plumgrid service only when there has been any change in the configuration files
- Removed restart of plumgrid service when only two directors are available
- Fixed unit tests accordingly

[lp:~bbaqar/charms/trusty/plumgrid-edge/opsvm]

25. By Bilal Baqar on 2016-03-25

Cleaned code

26. By Bilal Baqar on 2016-03-26

restart_on_changed

27. By Bilal Baqar on 2016-03-26

Fixed lint and unit_tests

28. By Bilal Baqar on 2016-03-26

Improved dir ips string

29. By Bilal Baqar on 2016-03-27

Removed pkg purge in stop hook

30. By Bilal Baqar on 2016-03-28

fixing unit_test

[Javeria Khan (javeria-ak)]

Looks good to me functionally.

review: Approve

[Junaid Ali (junaidali)]

Looks good.

review: Approve

=== modified file 'hooks/pg_edge_context.py'
--- hooks/pg_edge_context.py	2016-03-12 21:32:55 +0000
+++ hooks/pg_edge_context.py	2016-03-28 14:31:59 +0000
@@ -16,16 +16,23 @@
 )
 
 
-def _pg_dir_settings():
+def _pg_dir_context():
     '''
     Inspects relation with PLUMgrid director.
     '''
-    director_ips = []
+    ctxt = {
+        'opsvm_ip': '127.0.0.1',
+        'director_ips': [],
+    }
     for rid in relation_ids('plumgrid'):
         for unit in related_units(rid):
             rdata = relation_get(rid=rid, unit=unit)
-            director_ips.append(str(get_host_ip(rdata['private-address'])))
-    return director_ips
+            ctxt['director_ips'
+                 ].append(str(get_host_ip(rdata['private-address'])))
+            if "opsvm_ip" in rdata:
+                ctxt['opsvm_ip'] = \
+                    rdata['opsvm_ip']
+    return ctxt
 
 
 class PGEdgeContext(context.NeutronContext):
@@ -62,16 +69,16 @@
         if not pg_ctxt:
             return {}
 
-        pg_dir_ips = ''
-        pg_dir_settings = sorted(_pg_dir_settings())
-        single_ip = True
-        for ip in pg_dir_settings:
-            if single_ip:
-                pg_dir_ips = str(ip)
-                single_ip = False
-            else:
-                pg_dir_ips = pg_dir_ips + ',' + str(ip)
-        pg_ctxt['local_ip'] = pg_dir_ips
+        pg_dir_context = _pg_dir_context()
+        pg_dir_ips = sorted(pg_dir_context['director_ips'])
+        dir_count = len(pg_dir_ips)
+        pg_ctxt['director_ips_string'] = (str(pg_dir_ips[0]) + ',' +
+                                          str(pg_dir_ips[1]) + ',' +
+                                          str(pg_dir_ips[2])
+                                          if dir_count == 3 else
+                                          str(pg_dir_ips[0])
+                                          if dir_count == 1 else
+                                          '')
         unit_hostname = gethostname()
         pg_ctxt['pg_hostname'] = unit_hostname
         pg_ctxt['pg_fqdn'] = getfqdn()
@@ -80,5 +87,6 @@
         pg_ctxt['fabric_interface'] = get_fabric_interface()
         pg_ctxt['label'] = unit_hostname
         pg_ctxt['fabric_mode'] = 'host'
+        pg_ctxt['opsvm_ip'] = pg_dir_context['opsvm_ip']
 
         return pg_ctxt

=== modified file 'hooks/pg_edge_hooks.py'
--- hooks/pg_edge_hooks.py	2016-03-25 16:57:36 +0000
+++ hooks/pg_edge_hooks.py	2016-03-28 14:31:59 +0000
@@ -19,7 +19,6 @@
 
 from charmhelpers.fetch import (
     apt_install,
-    apt_purge,
     configure_sources,
 )
 
@@ -27,6 +26,7 @@
     register_configs,
     ensure_files,
     restart_pg,
+    restart_map,
     stop_pg,
     determine_packages,
     load_iovisor,
@@ -34,7 +34,9 @@
     ensure_mtu,
     add_lcm_key,
     fabric_interface_changed,
-    load_iptables
+    load_iptables,
+    restart_on_change,
+    director_cluster_ready
 )
 
 hooks = Hooks()
@@ -57,18 +59,16 @@
     add_lcm_key()
 
 
[e-mail]('plumgrid-relation-joined')
 @hooks.hook('plumgrid-relation-changed')
-def director_joined():
+@restart_on_change(restart_map())
+def director_changed():
     '''
     This hook is run when relation between plumgrid-edge and
     plumgrid-director is made or changed.
     '''
-    ensure_mtu()
-    ensure_files()
-    add_lcm_key()
-    CONFIGS.write_all()
-    restart_pg()
+    if director_cluster_ready():
+        ensure_mtu()
+        CONFIGS.write_all()
 
 
 @hooks.hook('neutron-plugin-relation-joined')
@@ -103,7 +103,6 @@
         charm_config.changed('plumgrid-build') or
         charm_config.changed('install_keys') or
             charm_config.changed('iovisor-build')):
-        ensure_files()
         stop_pg()
         configure_sources(update=True)
         pkgs = determine_packages()
@@ -124,12 +123,10 @@
 
 
 @hooks.hook('upgrade-charm')
+@restart_on_change(restart_map())
 def upgrade_charm():
-    load_iptables()
     ensure_mtu()
-    ensure_files()
     CONFIGS.write_all()
-    restart_pg()
 
 
 @hooks.hook('stop')
@@ -138,10 +135,6 @@
     This hook is run when the charm is destroyed.
     '''
     stop_pg()
-    remove_iovisor()
-    pkgs = determine_packages()
-    for pkg in pkgs:
-        apt_purge(pkg, fatal=False)
 
 
 def main():

=== modified file 'hooks/pg_edge_utils.py'
--- hooks/pg_edge_utils.py	2016-03-21 18:59:43 +0000
+++ hooks/pg_edge_utils.py	2016-03-28 14:31:59 +0000
@@ -12,7 +12,6 @@
 from copy import deepcopy
 from charmhelpers.contrib.openstack.neutron import neutron_plugin_attribute
 from charmhelpers.contrib.storage.linux.ceph import modprobe
-from charmhelpers.core.host import set_nic_mtu
 from charmhelpers.contrib.openstack import templating
 from charmhelpers.core.hookenv import (
     log,
@@ -32,6 +31,8 @@
     service_start,
     service_stop,
     service_running,
+    path_hash,
+    set_nic_mtu
 )
 from charmhelpers.fetch import (
     apt_cache,
@@ -49,6 +50,7 @@
 PG_HN_CONF = '%s/conf/etc/hostname' % PG_LXC_DATA_PATH
 PG_HS_CONF = '%s/conf/etc/hosts' % PG_LXC_DATA_PATH
 PG_IFCS_CONF = '%s/conf/pg/ifcs.conf' % PG_LXC_DATA_PATH
+OPS_CONF = '%s/conf/etc/00-pg.conf' % PG_LXC_DATA_PATH
 AUTH_KEY_PATH = '%s/root/.ssh/authorized_keys' % PG_LXC_DATA_PATH
 SUDOERS_CONF = '/etc/sudoers.d/ifc_ctl_sudoers'
 FILTERS_CONF_DIR = '/etc/nova/rootwrap.d'
@@ -67,6 +69,10 @@
         'services': ['plumgrid'],
         'contexts': [pg_edge_context.PGEdgeContext()],
     }),
+    (OPS_CONF, {
+        'services': ['plumgrid'],
+        'contexts': [pg_edge_context.PGEdgeContext()],
+    }),
     (PG_IFCS_CONF, {
         'services': [],
         'contexts': [pg_edge_context.PGEdgeContext()],
@@ -410,3 +416,24 @@
             return None
     else:
         return None
+
+
+def director_cluster_ready():
+    dirs_count = len(pg_edge_context._pg_dir_context()['director_ips'])
+    return True if dirs_count == 1 or dirs_count == 3 else False
+
+
+def restart_on_change(restart_map):
+    """
+    Restart services based on configuration files changing
+    """
+    def wrap(f):
+        def wrapped_f(*args, **kwargs):
+            checksums = {path: path_hash(path) for path in restart_map}
+            f(*args, **kwargs)
+            for path in restart_map:
+                if path_hash(path) != checksums[path]:
+                    restart_pg()
+                    break
+        return wrapped_f
+    return wrap

=== removed symlink 'hooks/plumgrid-relation-joined'
=== target was u'pg_edge_hooks.py'
=== added file 'templates/kilo/00-pg.conf'
--- templates/kilo/00-pg.conf	1970-01-01 00:00:00 +0000
+++ templates/kilo/00-pg.conf	2016-03-28 14:31:59 +0000
@@ -0,0 +1,1 @@
+$template ls_json,"{{'{'}}{{'%'}}timestamp:::date-rfc3339,jsonf:@timestamp%,%source:::jsonf:@source_host%,%msg:::json%}":syslogtag,isequal,"pg:" @{{ opsvm_ip }}:6000;ls_json

=== modified file 'templates/kilo/plumgrid.conf'
--- templates/kilo/plumgrid.conf	2015-07-29 18:19:18 +0000
+++ templates/kilo/plumgrid.conf	2016-03-28 14:31:59 +0000
@@ -1,4 +1,4 @@
-plumgrid_ip={{ local_ip }}
+plumgrid_ip={{ director_ips_string }}
 plumgrid_port=8001
 mgmt_dev={{ interface }}
 label={{ label}}

=== modified file 'unit_tests/test_pg_edge_context.py'
--- unit_tests/test_pg_edge_context.py	2016-03-12 20:58:04 +0000
+++ unit_tests/test_pg_edge_context.py	2016-03-28 14:31:59 +0000
@@ -35,13 +35,13 @@
     @patch.object(charmhelpers.contrib.openstack.context,
                   'config_flags_parser')
     @patch.object(context.PGEdgeContext, '_save_flag_file')
-    @patch.object(context, '_pg_dir_settings')
+    @patch.object(context, '_pg_dir_context')
     @patch.object(charmhelpers.contrib.openstack.context,
                   'neutron_plugin_attribute')
     @patch.object(utils, 'get_mgmt_interface')
     @patch.object(utils, 'get_fabric_interface')
     def test_neutroncc_context_api_rel(self, _fabric_int, _mgmt_int,
-                                       _npa, _pg_dir_settings,
+                                       _npa, _pg_dir_context,
                                        _save_flag_file, _config_flag,
                                        _unit_get, _unit_priv_ip, _config,
                                        _is_clus, _https, _ens_pkgs):
@@ -61,24 +61,26 @@
 
         self.maxDiff = None
         _npa.side_effect = mock_npa
-        _unit_get.return_value = '192.168.100.201'
-        _unit_priv_ip.return_value = '192.168.100.201'
+        _unit_get.return_value = '192.168.100.203'
+        _unit_priv_ip.return_value = '192.168.100.203'
         self.gethostname.return_value = 'node0'
         self.getfqdn.return_value = 'node0.maas'
         _is_clus.return_value = False
         _config_flag.return_value = False
-        _pg_dir_settings.return_value = {'pg_dir_ip': '192.168.100.201'}
+        _pg_dir_context.return_value = {'director_ips': ['192.168.100.201'],
+                                        'opsvm_ip': '127.0.0.1'}
         _mgmt_int.return_value = 'juju-br0'
         _fabric_int.return_value = 'juju-br0'
         napi_ctxt = context.PGEdgeContext()
         expect = {
             'config': 'neutron.randomconfig',
             'core_plugin': 'neutron.randomdriver',
-            'local_ip': 'pg_dir_ip',
+            'local_ip': '192.168.100.203',
+            'director_ips_string': '192.168.100.201',
             'network_manager': 'neutron',
             'neutron_plugin': 'plumgrid',
             'neutron_security_groups': None,
-            'neutron_url': 'https://192.168.100.201:9696',
+            'neutron_url': 'https://192.168.100.203:9696',
             'pg_hostname': 'node0',
             'pg_fqdn': 'node0.maas',
             'interface': 'juju-br0',
@@ -86,5 +88,6 @@
             'label': 'node0',
             'fabric_mode': 'host',
             'neutron_alchemy_flags': False,
+            'opsvm_ip': '127.0.0.1',
         }
         self.assertEquals(expect, napi_ctxt())

=== modified file 'unit_tests/test_pg_edge_hooks.py'
--- unit_tests/test_pg_edge_hooks.py	2016-03-24 12:36:29 +0000
+++ unit_tests/test_pg_edge_hooks.py	2016-03-28 14:31:59 +0000
@@ -18,7 +18,6 @@
 TO_PATCH = [
     'remove_iovisor',
     'apt_install',
-    'apt_purge',
     'CONFIGS',
     'log',
     'configure_sources',
@@ -32,7 +31,8 @@
     'config',
     'relation_set',
     'relation_ids',
-    'load_iptables'
+    'load_iptables',
+    'director_cluster_ready'
 ]
 NEUTRON_CONF_DIR = "/etc/neutron"
 
@@ -64,13 +64,11 @@
         self.ensure_files.assert_called_with()
         self.add_lcm_key.assert_called_with()
 
-    def test_plumgrid_joined(self):
-        self._call_hook('plumgrid-relation-joined')
+    def test_plumgrid_changed(self):
+        self._call_hook('plumgrid-relation-changed')
+        self.director_cluster_ready.return_value = True
         self.ensure_mtu.assert_called_with()
-        self.ensure_files.assert_called_with()
-        self.add_lcm_key.assert_called_with()
         self.CONFIGS.write_all.assert_called_with()
-        self.restart_pg.assert_called_with()
 
     def test_neutron_plugin_joined(self):
         self.test_config.set('metadata-shared-key', 'plumgrid')
@@ -84,8 +82,5 @@
         )
 
     def test_stop(self):
-        _pkgs = ['plumgrid-lxc', 'iovisor-dkms']
         self._call_hook('stop')
         self.stop_pg.assert_called_with()
-        self.remove_iovisor.assert_called_with()
-        self.determine_packages.return_value = _pkgs

=== modified file 'unit_tests/test_pg_edge_utils.py'
--- unit_tests/test_pg_edge_utils.py	2015-08-24 16:22:15 +0000
+++ unit_tests/test_pg_edge_utils.py	2016-03-28 14:31:59 +0000
@@ -54,6 +54,7 @@
                  nutils.PG_HN_CONF,
                  nutils.PG_HS_CONF,
                  nutils.PG_IFCS_CONF,
+                 nutils.OPS_CONF,
                  '/etc/nova/rootwrap.d/network.filters']
         self.assertItemsEqual(_regconfs.configs, confs)
 
@@ -70,6 +71,7 @@
             (nutils.PG_CONF, ['plumgrid']),
             (nutils.PG_HN_CONF, ['plumgrid']),
             (nutils.PG_HS_CONF, ['plumgrid']),
+            (nutils.OPS_CONF, ['plumgrid']),
             (nutils.PG_IFCS_CONF, []),
             (nutils.FILTERS_CONF, []),
         ])