Merge lp:~asac/phablet-tools/remove-chmod666-uinput-hack into lp:phablet-tools

[Alexander Sack]

now that phablet is proper member of sudo/autopilot, remove chmod 666 /dev/uinput hack

remove chmod 666 hack previously added to support autopilot not being able to access /dev/uinput in unity8 tests. This is now fixed by making phablet member of sudo and hence automatically member of autopilot group (which owns the uinput file according to udev rule).

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:168
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~asac/phablet-tools/remove-chmod666-uinput-hack/+merge/182121/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/145/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-amd64-ci/88
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-armhf-ci/88
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-i386-ci/88

Click here to trigger a rebuild:
http://s-jenkins:8080/job/phablet-tools-ci/145/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:168
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/147/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-amd64-ci/90
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-armhf-ci/90
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-i386-ci/90

Click here to trigger a rebuild:
http://s-jenkins:8080/job/phablet-tools-ci/147/rebuild

review: Approve (continuous-integration)

[Sergio Schvezov (sergiusens)]

phablet first needs to belong to the autopilot group.

>>> from evdev import UInput, ecodes as e
>>> ui = UInput()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/dist-packages/evdev/uinput.py", line 66, in __init__
    self._verify()
  File "/usr/lib/python2.7/dist-packages/evdev/uinput.py", line 186, in _verify
    raise UInputError(msg.format(self.devnode))
evdev.uinput.UInputError: "/dev/uinput" cannot be opened for writing
>>>
phablet@ubuntu-phablet:/$ ls -l /dev/uinput
crw-rw---- 1 root autopilot 10, 223 Aug 27 14:36 /dev/uinput
phablet@ubuntu-phablet:/$ groups
phablet adm tty dialout cdrom sudo dip video plugdev radio bluetooth android_graphics android_input audio sdcard_rw gps android_net3 android_net android_net2

review: Needs Fixing

Unmerged revisions

168. By Alexander Sack on 2013-08-26

remove chmod 666 /dev/uinput hack now that phablet is proper member of sudo/autopilot

=== modified file 'phablet-test-run'
--- phablet-test-run	2013-07-18 16:02:57 +0000
+++ phablet-test-run	2013-08-26 15:48:45 +0000
@@ -103,7 +103,6 @@
 }
 
 run_test() {
-    exec_with_adb chmod 666 /dev/uinput
     set +e
     if [ "$RESULTDIR" ]; then
         exec_with_ssh autopilot run -o /tmp/test_results.xml -f xml $TESTSUITE