lp:~alexmurray/whoopsie/whoopsie

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:whoopsie

Iain Lane (community): Needs Information on 2019-07-09

Diff: 26 lines (+3/-3)

2 files modified

src/utils.c (+1/-1)
src/whoopsie.c (+2/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1830863: Integer overflow in parse_report (whoopsie.c:425)

Undecided

New

Link a bug report

Related blueprints

707. By Alex Murray on 2019-07-09

src/utils.c: Don't use strncpy where strcpy will suffice

The code is already very careful to allocate a buffer large enough for the
length of the filename extension so there is no need to use strncpy to
append this to the new filename - instead can just use strcpy.

With the previous code, whoopsie would FTBFS against gcc 8.3.0 due to the
following error as a result of this use of strncpy - so changing to strcpy
fixes the build:

In file included from /usr/include/string.h:494,
                 from src/utils.c:19:
In function ‘strncpy’,
    inlined from ‘change_file_extension’ at src/utils.c:92:5,
    inlined from ‘change_file_extension’ at src/utils.c:67:1:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
  106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/utils.c: In function ‘change_file_extension’:
src/utils.c:89:15: note: length computed here
   89 | ext_len = strlen (extension);
      | ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

706. By Alex Murray on 2019-07-09

src/whoopsie.c: Integer overflow when handling large crash dumps (LP: #1830863)

Don't use signed integer types for lengths to ensure large crash dumps do
not cause signed integer overflow

CVE-2019-11476

705. By Steve Langasek on 2019-07-01

releasing package whoopsie version 0.2.65

704. By Steve Langasek on 2019-07-01

Merge lp:~seb128/whoopsie/nm-build-fix

703. By Brian Murray on 2019-02-21

releasing package whoopsie version 0.2.64

702. By Brian Murray on 2019-02-21

When the package is being purged remove /var/lib/whoopsie/whoopsie-id.
(LP: #1816767)

701. By Brian Murray on 2018-11-21

releasing package whoopsie version 0.2.63

700. By Brian Murray on 2018-11-20

if the only thing in the .uploaded is the OOPS ID then OOPS ID seems unnecessary.

699. By Brian Murray on 2018-11-19

Write the reported OOPS ID to the .uploaded file. (LP: #1582470)

698. By Brian Murray on 2018-04-06

releasing package whoopsie version 0.2.62