Merge lp:~alexlist/charms/precise/nova-cloud-controller/missing-python-mysqldb into lp:~charmers/charms/precise/nova-cloud-controller/trunk

Proposed by Alexander List
Status: Merged
Approved by: Alexander List
Approved revision: 58
Merged at revision: 58
Proposed branch: lp:~alexlist/charms/precise/nova-cloud-controller/missing-python-mysqldb
Merge into: lp:~charmers/charms/precise/nova-cloud-controller/trunk
Diff against target: 16 lines (+2/-1)
1 file modified
hooks/nova_cc_utils.py (+2/-1)
To merge this branch: bzr merge lp:~alexlist/charms/precise/nova-cloud-controller/missing-python-mysqldb
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Review via email: mp+201473@code.launchpad.net

Description of the change

nova-cloud-controller is missing a dependency on python-mysqldb (which in turn pulls libmysqlclient ...)

2014-01-10 16:50:58 INFO juju.worker.uniter context.go:255 HOOK 2014-01-10 16:50:58.608 11341 CRITICAL nova [-] No module named MySQLdb
[...]
2014-01-10 16:50:58 INFO juju.worker.uniter context.go:255 HOOK 2014-01-10 16:50:58.608 11341 TRACE nova return __import__('MySQLdb')
2014-01-10 16:50:58 INFO juju.worker.uniter context.go:255 HOOK 2014-01-10 16:50:58.608 11341 TRACE nova ImportError: No module named MySQLdb

This prevents installation in my case (charm revno 57, precise)

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

Looks fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/nova_cc_utils.py'
2--- hooks/nova_cc_utils.py 2013-10-28 19:03:14 +0000
3+++ hooks/nova_cc_utils.py 2014-01-13 17:57:28 +0000
4@@ -43,11 +43,12 @@
5
6 CLUSTER_RES = 'res_nova_vip'
7
8-# removed from original: python-mysqldb python-keystone charm-helper-sh
9+# removed from original: charm-helper-sh
10 BASE_PACKAGES = [
11 'apache2',
12 'haproxy',
13 'python-keystoneclient',
14+ 'python-mysqldb',
15 'uuid',
16 ]
17

Subscribers

People subscribed via source and target branches