Merge lp:~ahasenack/charms/precise/openstack-dashboard/use-charm-dir into lp:~openstack-charmers/charms/precise/openstack-dashboard/ha-support

Proposed by Andreas Hasenack
Status: Merged
Merged at revision: 33
Proposed branch: lp:~ahasenack/charms/precise/openstack-dashboard/use-charm-dir
Merge into: lp:~openstack-charmers/charms/precise/openstack-dashboard/ha-support
Diff against target: 70 lines (+11/-10)
4 files modified
hooks/horizon-common (+4/-3)
hooks/horizon-relations (+4/-4)
hooks/lib/openstack-common (+2/-2)
revision (+1/-1)
To merge this branch: bzr merge lp:~ahasenack/charms/precise/openstack-dashboard/use-charm-dir
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+161232@code.launchpad.net

Description of the change

This branch changes the charm to use CHARM_DIR instead of a hardcoded path. That makes it compatible with both juju-core and juju.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/horizon-common'
2--- hooks/horizon-common 2013-03-22 11:23:33 +0000
3+++ hooks/horizon-common 2013-04-26 20:49:42 +0000
4@@ -5,11 +5,12 @@
5
6 PACKAGES="openstack-dashboard python-keystoneclient python-memcache memcached haproxy"
7 LOCAL_SETTINGS="/etc/openstack-dashboard/local_settings.py"
8+HOOKS_DIR="$CHARM_DIR/hooks"
9
10-if [[ -e "$CHARM_DIR/lib/openstack-common" ]] ; then
11- . $CHARM_DIR/lib/openstack-common
12+if [[ -e "$HOOKS_DIR/lib/openstack-common" ]] ; then
13+ . $HOOKS_DIR/lib/openstack-common
14 else
15- juju-log "ERROR: Couldn't load $CHARM_DIR/lib/openstack-common." && exit 1
16+ juju-log "ERROR: Couldn't load $HOOKS_DIR/lib/openstack-common." && exit 1
17 fi
18
19 set_or_update() {
20
21=== modified file 'hooks/horizon-relations'
22--- hooks/horizon-relations 2013-04-08 16:17:03 +0000
23+++ hooks/horizon-relations 2013-04-26 20:49:42 +0000
24@@ -1,13 +1,13 @@
25 #!/bin/bash
26 set -e
27
28-CHARM_DIR=$(dirname $0)
29+HOOKS_DIR="$CHARM_DIR/hooks"
30 ARG0=${0##*/}
31
32-if [[ -e $CHARM_DIR/horizon-common ]] ; then
33- . $CHARM_DIR/horizon-common
34+if [[ -e $HOOKS_DIR/horizon-common ]] ; then
35+ . $HOOKS_DIR/horizon-common
36 else
37- echo "ERROR: Could not load horizon-common from $CHARM_DIR"
38+ echo "ERROR: Could not load horizon-common from $HOOKS_DIR"
39 fi
40
41 function install_hook {
42
43=== modified file 'hooks/lib/openstack-common'
44--- hooks/lib/openstack-common 2013-03-15 18:43:15 +0000
45+++ hooks/lib/openstack-common 2013-04-26 20:49:42 +0000
46@@ -750,7 +750,7 @@
47 exit 1
48 fi
49 # our default unit_path
50- unit_path="/var/lib/juju/units/${JUJU_UNIT_NAME/\//-}/charm/scripts/scriptrc"
51+ unit_path="$CHARM_DIR/scripts/scriptrc"
52 echo $unit_path
53 tmp_rc="/tmp/${JUJU_UNIT_NAME/\//-}rc"
54
55@@ -759,7 +759,7 @@
56 do
57 if `echo $env_var | grep -q script_path`; then
58 # well then we need to reset the new unit-local script path
59- unit_path="/var/lib/juju/units/${JUJU_UNIT_NAME/\//-}/charm/${env_var/script_path=/}"
60+ unit_path="$CHARM_DIR/${env_var/script_path=/}"
61 else
62 echo "export $env_var" >> $tmp_rc
63 fi
64
65=== modified file 'revision'
66--- revision 2013-03-27 14:59:04 +0000
67+++ revision 2013-04-26 20:49:42 +0000
68@@ -1,1 +1,1 @@
69-27
70+28

Subscribers

People subscribed via source and target branches