Merge lp:~1chb1n/charms/trusty/neutron-gateway/next.normalize-makefile-test-deps into lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next

Proposed by Ryan Beisner
Status: Merged
Merged at revision: 149
Proposed branch: lp:~1chb1n/charms/trusty/neutron-gateway/next.normalize-makefile-test-deps
Merge into: lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next
Diff against target: 37 lines (+3/-2)
3 files modified
Makefile (+1/-1)
tests/00-setup (+1/-0)
tests/tests.yaml (+1/-1)
To merge this branch: bzr merge lp:~1chb1n/charms/trusty/neutron-gateway/next.normalize-makefile-test-deps
Reviewer Review Type Date Requested Status
Corey Bryant (community) Approve
Review via email: mp+273589@code.launchpad.net

Description of the change

Update test dependencies and normalize Makefiles across *oscharms.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #10591 neutron-gateway-next for 1chb1n mp273589
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/10591/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #11412 neutron-gateway-next for 1chb1n mp273589
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/11412/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #7162 neutron-gateway-next for 1chb1n mp273589
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12699927/
Build: http://10.245.162.77:8080/job/charm_amulet_test/7162/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

^ totally unrelated amulet test fail. Re-running test anyway.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #7173 neutron-gateway-next for 1chb1n mp273589
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12701770/
Build: http://10.245.162.77:8080/job/charm_amulet_test/7173/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Undercloud issue, pending resolution.

Since this MP doesn't touch tests or hooks, amulet failures are irrelevant.

Revision history for this message
Corey Bryant (corey.bryant) :
review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #7181 neutron-gateway-next for 1chb1n mp273589
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/7181/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2015-08-22 04:58:53 +0000
3+++ Makefile 2015-10-06 17:21:07 +0000
4@@ -9,7 +9,7 @@
5 test:
6 @# Bundletester expects unit tests here.
7 @echo Starting unit tests...
8- @$(PYTHON) /usr/bin/nosetests --nologcapture --with-coverage unit_tests
9+ @$(PYTHON) /usr/bin/nosetests -v --nologcapture --with-coverage unit_tests
10
11 functional_test:
12 @echo Starting Amulet tests...
13
14=== modified file 'tests/00-setup'
15--- tests/00-setup 2015-08-22 04:58:53 +0000
16+++ tests/00-setup 2015-10-06 17:21:07 +0000
17@@ -5,6 +5,7 @@
18 sudo add-apt-repository --yes ppa:juju/stable
19 sudo apt-get update --yes
20 sudo apt-get install --yes amulet \
21+ distro-info-data \
22 python-cinderclient \
23 python-distro-info \
24 python-glanceclient \
25
26=== modified file 'tests/tests.yaml'
27--- tests/tests.yaml 2015-08-22 04:58:53 +0000
28+++ tests/tests.yaml 2015-10-06 17:21:07 +0000
29@@ -8,7 +8,7 @@
30 - ppa:juju/stable
31 packages:
32 - amulet
33- - python-amulet
34+ - distro-info-data
35 - python-cinderclient
36 - python-distro-info
37 - python-glanceclient

Subscribers

People subscribed via source and target branches