Comment 3 for bug 1133526

Revision history for this message
Malini Bhandaru (malini-k-bhandaru) wrote :

May be I am over thinking this one ...
How deep do we want this change? Initially I thought just outward facing, in a response body "expires_at" instead of "expires".
Then only tests that examine the response need change.

Then on re-reading the bug, may be we want internal token representations to conform to what we show users in a response.
We touch more files... test_auth.py and for that matter, does one assume that one has a v2 token or a v3 token there or make it work for both after checking whether token has "expires" or "expires_at" in its dictionary.

But then why stop there, do we change the token DB column to "expires_at" as opposed to "expires" to be fully consistent?
I am guessing too many DB scripts will not change because rarely will anyone migrate tokens .. these are ephemeral entities.

Thanks
Malini