[urlgrab] Not handling posting exceptions well

Bug #702798 reported by Stefano Rivera
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ibid
Fix Released
Low
Stefano Rivera

Bug Description

Query: aoeu oeu osth.com eoeiiuiu
ERROR:scripts.ibid-plugin:Exception occured in Grab processor of urlgrab plugin
Traceback (most recent call last):
  File "scripts/ibid-plugin", line 129, in <module>
    processor.process(event)
  File "./ibid/plugins/__init__.py", line 145, in process
    method(event, *match.groups())
  File "./ibid/plugins/urlgrab.py", line 82, in grab
    self._post_url(event, url)
  File "./ibid/plugins/urlgrab.py", line 137, in _post_url
    resp = opener.open(posturl).read()
  File "/usr/lib/python2.6/urllib2.py", line 391, in open
    response = self._open(req, data)
  File "/usr/lib/python2.6/urllib2.py", line 409, in _open
    '_open', req)
  File "/usr/lib/python2.6/urllib2.py", line 369, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.6/urllib2.py", line 1178, in https_open
    return self.do_open(httplib.HTTPSConnection, req)
  File "/usr/lib/python2.6/urllib2.py", line 1145, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 110] Connection timed out>

sqlite> select * from urls;
sqlite>

Didn't get stored due to the exception

Related branches

Revision history for this message
Stefano Rivera (stefanor) wrote :

I'm sure we used to handle this correctly.

Also, considering how commonly this slows the bot's responses down, I think it would be a good idea to move the title determination and delicious posting into an asynchronous action.

Changed in ibid:
assignee: nobody → Stefano Rivera (stefanor)
importance: Undecided → Low
milestone: none → 0.1.1
status: New → Triaged
Revision history for this message
Stefano Rivera (stefanor) wrote :

Asynchronous wishlist part of this bug split out into LP: #706225.

Changed in ibid:
status: Triaged → Fix Committed
status: Fix Committed → In Progress
Changed in ibid:
status: In Progress → Fix Committed
Changed in ibid:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.