New subordinate charm: OpenID/SSO support for Apache

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10645-results

I fixed both warnings from charm-proof even though we need to only support Trusty so it's not really our fault that on Vivid the categories/tags thing got changed. Also, the tests failed to start in the first place so the whole failure is not the charm's fault anyway. I wonder if someone checks these results to be sure they're not bogus?

The results (PASS) are in and available here: http://reports.vapour.ws/charm-tests/charm-bundle-test-10850-results

Caio,

Thanks for your contributions to the Juju community, and sharing this valuable gem with the community.

# Charm Tests

For Trusty charms one item we have asked charm authors is to include charm tests to ensure the quality of the charm continues to be consistent across all substrates, updates to Ubuntu, updates to Juju, and updates to the Charm itself. You can easily add a seed test to by issuing (given you have charm-tools installed):
  charm add tests

# Config

It is always advantageous to have a short section in the readme to help the user understand how to use config options and if there are any cavets with using config options.

For the config option of "authorized_teams" is for LP only or is this defined by the OpenID providers?

# Deploying

The charm successfully deploys and relates to trusty/apache2 charm. 'apache2ctl configtest' also runs successfully. I wasn't entirely sure what a good metric for a successful deployment should be. Suggest to add this to the readme.

# Knitpicks

Suggest to make the readme in markdown format so it renders a little more cleanly in jujucharms.com charm browser. You can see an example the readme template by issuing (given you have charm-tools installed):
  charm add readme

It would also be nice to have a suggested method for the user to verify the sub is working after relating and adding in the example virtualhost config (thanks for including that btw).

Suggest to add expose to the instructions on how to deploy, and an example set up for the apache2 charm.

# Summary

Overall this charm looks good and I can tell this has been in use by the PES team. There are a few knitpicks with the readme, but one item that does need addressing is adding charm tests. If the branch could be updated with even a seed charm tests and some quick updates to the readme I think this charm should be ready for the recommended portion of the charm store.

Again thanks for your work on this charm and your contribution to the Juju community.
-Antonio

Caio,

When you have added tests and, if you decide to, updated the Readme please put this bug into "Fix Commited" state and it will show back up in the review queue.

-thanks,

[Expired for Juju Charms Collection because there has been no activity for 60 days.]