Merge lp:~gotopad/do-plugins/Opera into lp:do-plugins/community

Proposed by gotopad
Status: Merged
Approved by: Alex Launi
Approved revision: 4
Merge reported by: Alex Launi
Merged at revision: not available
Proposed branch: lp:~gotopad/do-plugins/Opera
Merge into: lp:do-plugins/community
To merge this branch: bzr merge lp:~gotopad/do-plugins/Opera
Reviewer Review Type Date Requested Status
Alex Launi (community) community does-it-explode-test Approve
Do Plugins Team Pending
Review via email: mp+2099@code.launchpad.net
To post a comment you must log in.
Revision history for this message
gotopad (gotopad) wrote :

Plugin to index Opera 6 Bookmarks (based on the Epiphany-Bookmark Plugin).

Revision history for this message
Alex Launi (alexlauni) wrote :

You forgot to add the addin.xml file to the bzr tree. I can't test/merge without this. Other than that the code looks pretty good, some minor Mono guidelines fixes could be made; there should be a space between method calls, and parens:

myInstance.Method (arg1, arg2);

brackets should be on same line as property name:

public ICollection<IItem> Items {
    get { return items; }
}

If you're feeling ambitious, you could update this to the 0.7 API using IEnumerable<IItem> rather than Arrays, don't feel obligated to do this though, it would just be nice for me :P

review: Needs Fixing (community does-it-explode-test)
lp:~gotopad/do-plugins/Opera updated
2. By gotopad

Update Coding Guidelines

3. By gotopad

Added src-Directory

4. By gotopad

stupid bracket at try -.-

Revision history for this message
gotopad (gotopad) wrote :

The addin.xml file was just on the wrong place.
Now you can find the addin.xml in the src Directory.

I adapt the code to the mono coding guidelines : http://mono-project.com/Coding_Guidelines

I'm not familar with the 0.7 API, sorry for that.

Revision history for this message
Alex Launi (alexlauni) wrote :

Looks good, I'll merge this in tonight

review: Approve (community does-it-explode-test)

Subscribers

People subscribed via source and target branches

to all changes: